Change code references from code_review_notes to code_review_comments - #48136
Merged
Conversation
molly-moen
changed the title
molly-moen
marked this pull request as ready for review
September 16, 2022 22:19
maddiedierker
approved these changes
Sep 16, 2022
| # removed. | ||
| class CodeReviewComment < ApplicationRecord | ||
| # TODO: rename the table to code_review_notes | ||
| self.table_name = :code_review_notes |
Contributor
There was a problem hiding this comment.
TIL you can have a table with a different name than its model!
sureshc
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change code references from
code_review_notestable tocode_review_comments.code_review_commentsmakes more sense, but was previously the name of a v1 table. Now that table has been dropped we can use the name for v2.This PR changes all the code references from
code_review_notestocode_review_comments. There will be a follow up once this is deployed to change the table name itself.Links
Testing story
Tested that creating, deleting and getting comments still worked, and that all unit tests pass.
Follow-up work
Rename the table in the database.