pass course version name to batch certificate page - #48126
Merged
Conversation
bethanyaconnor
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes PLAT-1533. See #48000 and #48101 for context.
This PR does two user-visible things. when navigating to the batch certificates page from teacher home page, the batch certificate page will now show:
Everything user-facing in this PR is still hidden behind an experiment flag.
There are also these behind-the-scenes changes:
3. CurriculumHelper.find_matching_course_version now uses
get_from_cachemethods to avoid hitting the database4.
/certificate_images/...endpoint can now write any valid course name onto a blank certificate, not just csf (3adfd02)Screenshots
Custom certificates for AI for Oceans:
pass-course-name-batch.mp4
Custom certificates for CSP:
Testing story
Follow-up work
In the CSP screenshot, you can see the course name is written as csp-2021, instead of "Computer Science Principles ('22-'23)" This is tracked by PLAT-1888 and is up next (#48145).