Skip to content

pass course version name to batch certificate page - #48126

Merged
davidsbailey merged 12 commits into
stagingfrom
batch-course-version-by-name
Sep 19, 2022
Merged

pass course version name to batch certificate page#48126
davidsbailey merged 12 commits into
stagingfrom
batch-course-version-by-name

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Sep 15, 2022

Copy link
Copy Markdown
Member

Finishes PLAT-1533. See #48000 and #48101 for context.

This PR does two user-visible things. when navigating to the batch certificates page from teacher home page, the batch certificate page will now show:

  1. a customized certificate for that course
  2. the display name of the course, e.g. "A printable page with personalized AI for Oceans certificates will be generated."

Everything user-facing in this PR is still hidden behind an experiment flag.

There are also these behind-the-scenes changes:
3. CurriculumHelper.find_matching_course_version now uses get_from_cache methods to avoid hitting the database
4. /certificate_images/... endpoint can now write any valid course name onto a blank certificate, not just csf (3adfd02)

Screenshots

Custom certificates for AI for Oceans:

pass-course-name-batch.mp4

Screen Shot 2022-09-15 at 6 25 49 PM

Custom certificates for CSP:

Screen Shot 2022-09-15 at 6 37 21 PM

Testing story

  • I tested (1) manually. there is an existing eyes test which shows that the /certificates/batch page can show custom certificates, but that doesn't quite test this functionality end-to-end
  • (2) is covered by new UI tests
  • added unit tests for (3) and (4)

Follow-up work

In the CSP screenshot, you can see the course name is written as csp-2021, instead of "Computer Science Principles ('22-'23)" This is tracked by PLAT-1888 and is up next (#48145).

@davidsbailey
davidsbailey marked this pull request as ready for review September 16, 2022 19:46
@davidsbailey
davidsbailey requested a review from a team as a code owner September 16, 2022 19:46
@davidsbailey
davidsbailey requested review from a team and removed request for a team September 16, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants