Skip to content

HoC.com - Update UI on activity tiles (post-revert-version) - #48110

Merged
kelbyhawn merged 2 commits into
stagingfrom
revert-48108-revert-48080-hoc-activity-tiles-ui-update
Sep 19, 2022
Merged

HoC.com - Update UI on activity tiles (post-revert-version)#48110
kelbyhawn merged 2 commits into
stagingfrom
revert-48108-revert-48080-hoc-activity-tiles-ui-update

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

Make the activity tiles look like more cohesive units on https://hourofcode.com/us/learn and https://code.org/learn

  • Add a border
  • Round corners
  • Update spacing

Relevant info: Asana taskSlack convo re: discussion around truncating the details line


Before

Before

After

Screen Shot 2022-09-14 at 4 43 23 PM

@breville

Copy link
Copy Markdown
Member

Duplicating my comment from #48080 (comment):

Just to capture what we discussed:

  • The vertical spacing between tiles can match the horizontal spacing.
  • Ideally, we wouldn't need grey borders around the tile images, especially since some images already have their own borders. In the past, for similar tiles, we've been able to limit the grey border to the text area below. However, since some tutorials have white backgrounds, it seems we'll need to draw the grey border around all images.
  • Currently, the majority of tiles have a lot of whitespace below the text. A few tutorials have multi-line "detail strings" (as generated here) but our idea is to truncate them and to work with @ericfershtman to reduce them to something shorter in the gsheet. This way, we can adjust the tile size to suit the majority of tutorials.

For reference, grey border only around text:
Screen Shot 2022-09-14 at 4 36 12 PM

Grey border around image:
Screen Shot 2022-09-14 at 4 36 20 PM

@kelbyhawn
kelbyhawn requested a review from breville September 15, 2022 20:37

@breville breville left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on the details here!

@kelbyhawn
kelbyhawn merged commit 20157ca into staging Sep 19, 2022
@kelbyhawn
kelbyhawn deleted the revert-48108-revert-48080-hoc-activity-tiles-ui-update branch September 19, 2022 15:12
@kelbyhawn kelbyhawn added the hoc label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants