Upgrade to webpack 5 (3rd attempt) - #48105
Merged
maddiedierker merged 7 commits intoSep 22, 2022
Merged
Conversation
maddiedierker
force-pushed
the
revert-48103-revert-48021-revert-48020-revert-47093-webpack-5-upgrade
branch
from
September 14, 2022 22:58
8fc7d38 to
94c3521
Compare
added 3 commits
September 16, 2022 10:05
…tyles Refactor progress table style constants into SCSS module
…vert-47093-webpack-5-upgrade
…vert-47093-webpack-5-upgrade
maddiedierker
deleted the
revert-48103-revert-48021-revert-48020-revert-47093-webpack-5-upgrade
branch
September 22, 2022 20:29
This was referenced Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #48103, re-introducing the Webpack 5 upgrade. Includes the fix in #48113.
Description from original upgrade PR (#47093):
Builds on changes in #41990 and #46108, minus migration to dart-sass since that was shipped in #46235.
Upgrades our apps package from Webpack v4 to v5, along with upgrading related dependencies. See some notes taken throughout the process in this doc.
Most notably, we now have to supply our own Node polyfills. Webpack <= 4 automatically polyfilled Node libraries. With this upgrade, we now have to supply packages for the Node libraries we depend on. See
nodePolyfillConfiginapps/webpack.js, webpackresolve.fallbackdocs, and Webpack 5 Node Polyfills Upgrade Cheatsheet for more details.Other notable changes in this PR:
max_old_space_sizefrom 4096 to 5120 (for production build scripts only).