Skip to content

Revert "Revert "Revert "Upgrade to webpack 5""" - #48103

Merged
maddiedierker merged 1 commit into
stagingfrom
revert-48021-revert-48020-revert-47093-webpack-5-upgrade
Sep 14, 2022
Merged

Revert "Revert "Revert "Upgrade to webpack 5"""#48103
maddiedierker merged 1 commit into
stagingfrom
revert-48021-revert-48020-revert-47093-webpack-5-upgrade

Conversation

@maddiedierker

@maddiedierker maddiedierker commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #48021

Reverting again because SCSS modules broke. progressTableStyles.scss is sometimes treated as a global SCSS file and sometimes as a module, which doesn't work with Webpack 5 (I'm not sure why it worked in the first place). A little more detail:

// Sometimes we import like this
import './progressTableStyles.scss';
// In order to access these styles as global SCSS
<div className="progress-table"></div>

// Other times we import like this
import progressTableStyles from './progressTableStyles.scss';
// In order to access exported variables
const width = parseInt(progressTableStyles. MIN_COLUMN_WIDTH);

This issue is addressed in #48113.

@maddiedierker
maddiedierker merged commit 2d36c69 into staging Sep 14, 2022
@maddiedierker
maddiedierker deleted the revert-48021-revert-48020-revert-47093-webpack-5-upgrade branch September 14, 2022 22:15
This was referenced Sep 14, 2022
Merged
Merged
@sanchitmalhotra126 sanchitmalhotra126 mentioned this pull request Sep 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanchitmalhotra126 sanchitmalhotra126 Awaiting requested review from sanchitmalhotra126

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maddiedierker