Support sass on all pegasus sites - #48102
Merged
Merged
Conversation
Contributor
Author
|
@code-dot-org/infrastructure could use a quick check that supporting advocacy.code.org locally isn't a bad idea. |
epeach
reviewed
Sep 14, 2022
| config.hosts << "localhost.code.org" | ||
| config.hosts << "localhost.hourofcode.com" | ||
| config.hosts << "localhost.codeprojects.org" | ||
| config.hosts << "localhost-advocacy.code.org" |
epeach
approved these changes
Sep 14, 2022
epeach
left a comment
epeach
left a comment
There was a problem hiding this comment.
I don't fully understand how Sass works, but this looks like reasonable changes.
kelbyhawn
approved these changes
Sep 14, 2022
kelbyhawn
left a comment
kelbyhawn
left a comment
Contributor
There was a problem hiding this comment.
Yay! Thanks for doing this Ben 😄
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sass support to hourofcode.com (primary goal) and advocacy.code.org (why not). A sass file called
ben.scsswould be available at/css/generated/ben.css, which is the same pattern as we use in code.org currently.As an aside, now serves advocacy.code.org at localhost.advocacy.code.org:3000 in development, which it appears we registered to lookup localhost at some point, but isn't configured to work currently.
Links
Testing story
I added a scss file to the css directories in
pegasus/sites.v3/hourofcode.comandpegasus/sites.v3/advocacy.code.org, and used them to style some text on the homepage of each site. I also looked at the compiled css files at URLs like localhost.hourofcode.com:3000/css/generated/ben.css.