Skip to content

conditionally use new dashboard page for batch certificates - #48101

Merged
davidsbailey merged 8 commits into
stagingfrom
redirect-batch-certificates
Sep 15, 2022
Merged

conditionally use new dashboard page for batch certificates#48101
davidsbailey merged 8 commits into
stagingfrom
redirect-batch-certificates

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Sep 14, 2022

Copy link
Copy Markdown
Member

Continues PLAT-1533. Follows #48000, see that PR for context.

  1. redirects from code.org/certificates to studio.code.org/certificates/batch, if experiment is enabled
  2. clicking Print Certificates on teacher homepage now goes to /certificates/batch, if experiment is enabled
  3. strip trailing newlines to avoid blank certificates

screenshots

from new UI test:

td-print-certs.mp4

Testing story

  • manually verified (1)
  • (2) is covered by new UI tests

Deployment strategy

safe to deploy because behavior is unchanged for end users, who will not have the experiment enabled

Follow-up work

pass the course name from teacher homepage to /certificates/batch, and customize the certificate there appropriately

@davidsbailey davidsbailey changed the title Redirect batch certificates conditionally use new dashboard page for batch certificates Sep 14, 2022
@davidsbailey
davidsbailey marked this pull request as ready for review September 15, 2022 15:57
@davidsbailey
davidsbailey requested review from a team September 15, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants