Adding Warning to Hidden Assessments form LockDialog - #48078
Merged
Conversation
hannahbergam
marked this pull request as ready for review
September 14, 2022 19:37
8 tasks
Contributor
|
Thanks Hannah! Looks great 🎉 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the lesson lock dialog to include a warning (plus instructions) if the assessment is currently hidden.
isHidden is already being sent to the lesson tile, so sending it down to LockDialog as a prop as well.
Additional cleanup in the dialog includes switching over all commonMsg instances to i18n.
Links
Testing story
Added two tests in LessonLockDialogTest- one each to ensure the message appears when the lesson is hidden, and not otherwise.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: