Keep code review submit button disabled until there is text - #48069
Merged
Conversation
sanchitmalhotra126
marked this pull request as ready for review
September 13, 2022 16:05
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw an issue where the submit button would sometimes get enabled even if there was no text in the comment box. This was due to the fact that when there's no text, the comment text value may still contain newline characters (either
'\n'for only paragraph text or'```\n\n\n```\n'for code block markdown + paragraph). This adds a check which trims newlines to check if the comment contents are actually empty. Trying to save empty comments would result in a 404 anyway but this issue was causing some flakiness in UI tests.Links
JIRA: https://codedotorg.atlassian.net/browse/JAVA-683
Testing story
Tested locally with empty text, newlines, and spaces.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: