Handle FatalErrors in Java Lab - #48061
Merged
Merged
Conversation
fisher-alice
marked this pull request as ready for review
September 14, 2022 20:56
molly-moen
approved these changes
Sep 14, 2022
molly-moen
left a comment
molly-moen
left a comment
Contributor
There was a problem hiding this comment.
LGTM! If we end up adding more fatal errors we may want to generalize the key so we don't need to keep updating this list :)
sanchitmalhotra126
approved these changes
Sep 15, 2022
| INTERNAL_RUNTIME_EXCEPTION: 'INTERNAL_RUNTIME_EXCEPTION', | ||
| INVALID_CLASS: 'INVALID_CLASS', | ||
| INVALID_JAVA_FILE_NAME: 'INVALID_JAVA_FILE_NAME', | ||
| INVALID_MAIN_METHOD: 'INVALID_MAIN_METHOD', |
Contributor
There was a problem hiding this comment.
Thanks for alphabetizing!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR handles FatalErrors in Java Lab. Currently for fatal errors, the fatal error message is printed (default case). This may be confusing to users in that FatalErrors are typically not related to their program (out of memory, out of disk space, etc).
This will update the message to 'Oops. We hit an error on our side...'.
Links
jira ticket - Handle FatalErrors in Java Lab
Testing story
I ran javabuilder locally and forced a fatal error by adding the following to line 115 in WebSocketServer.java:
throw new FatalError(FatalErrorKey.LOW_DISK_SPACE);I also tested with the other two fatal errors. Below is the screencast video when javabuilder is run locally.
fatalerrortests.mp4
PR Checklist: