Skip to content

DTP (Test > Production: dc4db3ea) - #48059

Merged
mikeharv merged 42 commits into
productionfrom
dtp_candidate_dc4db3ea
Sep 12, 2022
Merged

DTP (Test > Production: dc4db3ea)#48059
mikeharv merged 42 commits into
productionfrom
dtp_candidate_dc4db3ea

Conversation

@mikeharv

Copy link
Copy Markdown
Contributor

No description provided.

Erin Peach and others added 30 commits August 17, 2022 14:28
Quoting from the documentation ([docs.rubocop.org](https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsblank), [rubydoc.info](https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/Blank)):

> Checks for code that can be written with simpler conditionals using `Object#blank?` defined by Active Support.

There is certainly an argument to be made that there are situations in which `!foo.present?` and `something unless foo.present?` can be more readable than `foo.blank?` and `something if foo.blank?`, depending on the specific variable names involved, but I think they're rare enough that the consistency we gain by enabling this rule is worth it.
Fix Violations of and Reenable `Rails/Blank`
DTT (Staging > Test) [robo-dtt]
@mikeharv
mikeharv requested review from a team as code owners September 12, 2022 20:10
@mikeharv
mikeharv merged commit cace01d into production Sep 12, 2022
@mikeharv
mikeharv deleted the dtp_candidate_dc4db3ea branch September 12, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants