Skip to content

Add new DataDoc frontend - #48055

Merged
megcrenshaw merged 7 commits into
stagingfrom
add-new-doc-frontend
Sep 13, 2022
Merged

Add new DataDoc frontend#48055
megcrenshaw merged 7 commits into
stagingfrom
add-new-doc-frontend

Conversation

@megcrenshaw

@megcrenshaw megcrenshaw commented Sep 12, 2022

Copy link
Copy Markdown

@TurnerRiley and I paired on this PR, which finishes functionality to add a new Data Doc.

This work is part of https://codedotorg.atlassian.net/browse/PLAT-1279 –– Curriculum Writers can add new Data Docs.

To see functionality, go to http://localhost-studio.code.org:3000/data_docs/new. It should make you add Levelbuilder permissions to your local account before you can view the page, and you should be able to put in some basic stuff. What actually happens after you submit will come in a separate PR (see follow-up work).

Links

Spec
Engineering Plan

Testing story

Frontend tests are here, and backend tests were in a separate PR

See current functionality at https://watch.screencastify.com/v/oZNKYyr2abaEpXELxkeT
.

Deployment strategy

Follow-up work

  • Create page to actually see the DataDoc that was created –– this is a separate work item in the engineering plan. We should redirect to the corresponding page once a data doc is created.
  • Add UI test once we have the show page working.

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@megcrenshaw megcrenshaw changed the title Add new doc frontend Add new DataDoc frontend Sep 12, 2022
@megcrenshaw
megcrenshaw requested a review from a team September 12, 2022 21:00

@davidsbailey davidsbailey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work team! :-)

@megcrenshaw
megcrenshaw merged commit 6901fb2 into staging Sep 13, 2022
@megcrenshaw
megcrenshaw deleted the add-new-doc-frontend branch September 13, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants