Skip to content

Fix invalid font: Gotham 3r -> Gotham 4r - #48046

Merged
breville merged 1 commit into
stagingfrom
fix-invalid-font
Sep 14, 2022
Merged

Fix invalid font: Gotham 3r -> Gotham 4r#48046
breville merged 1 commit into
stagingfrom
fix-invalid-font

Conversation

@breville

@breville breville commented Sep 10, 2022

Copy link
Copy Markdown
Member

We don't have a "Gotham 3r", so update all such references to "Gotham 4r".

@breville
Fix invalid font: Gotham 3r -> Gotham 4r
1386138 
We don't have a "Gotham 3r", so update all such references to "Gotham
4r".
@breville
breville requested review from a team and kelbyhawn September 10, 2022 04:25
bencodeorg
bencodeorg approved these changes Sep 12, 2022
View reviewed changes

@bencodeorg bencodeorg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding, where do we specify which fonts we have? Always have trial and errored this sort of thing in the past.

@kelbyhawn

kelbyhawn commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

For my understanding, where do we specify which fonts we have? Always have trial and errored this sort of thing in the past.

I'd also be interested in seeing what it would take to refactor how fonts are implemented across the site so instead of using font-family to define a weight we can use the font-weight property.

@maddiedierker

maddiedierker commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

@bencodeorg and @kelbyhawn great questions! i did a deep dive on this somewhat recently so i figured i'd knowledge-share here...

this is how fonts are created/loaded in dashboard and apps:

@breville do you know how this works for pegasus? i know pegasus can access shared/css/font.scss since it's in shared/, but does it piggyback on any of the other dashboard setup, or are fonts completely separate in pegasus?

maddiedierker
maddiedierker approved these changes Sep 12, 2022
View reviewed changes

@maddiedierker maddiedierker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this clean-up!!

@breville

breville commented Sep 14, 2022

Copy link
Copy Markdown
Member Author

It appears that Pegasus uses its own full set of the fonts in code.org/public/fonts. It also has a subset in code.org/public/css/fonts.css, which are used before the full set are loaded, as implemented here.

@breville
breville merged commit 8bfc565 into staging Sep 14, 2022
@breville
breville deleted the fix-invalid-font branch September 14, 2022 19:53
@sanchitmalhotra126 sanchitmalhotra126 mentioned this pull request Sep 16, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kelbyhawn kelbyhawn kelbyhawn approved these changes
@bencodeorg bencodeorg bencodeorg approved these changes
+1 more reviewer
@maddiedierker maddiedierker maddiedierker approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@breville @kelbyhawn @maddiedierker @bencodeorg