Upgrade FatalErrorDialog story - #48045
Conversation
bencodeorg
left a comment
bencodeorg
left a comment
There was a problem hiding this comment.
Tangent to this PR, but curious about the "still exists on our old storybook site" point -- I remember digging into this a bit with Maddie a year ago. Looks like I wrote up a ticket that is in our "xteam" Jira graveyard:
https://codedotorg.atlassian.net/browse/XTEAM-355
@madelynkasula do you have thoughts/visions for our storybook site after the upgrade? Sorry if this was discussed at Storybook time on Friday and I missed it.
no vision, just that we need to fix this! since we've put some work into storybook now, it seems like a good time to address this tech debt and fix the storybook deploy so that people outside engineering can actually look at storybook. @jmkulwik how do you think we could get this work scheduled? |
maddiedierker
left a comment
maddiedierker
left a comment
There was a problem hiding this comment.
good call to just remove the ApplabVisualizationColumn story -- looking back at it, that component is too specific for storybook, so it doesn't make sense to document it there
Hmm let's chat at our next 1:1. |
3 participants
Remove the ApplabVisualizationColumn story because it doesn't display a reusable component.
(For now, the old ApplabVisualizationColumn can be found on our old Storybook site. I'd definitely appreciate a second set of eyes on whether it should be removed!)
Updated the FatalErrorDialog story.
New FatalErrorDialog story!
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: