Hiding old cookie banner if new banner is shown - #48044
Merged
Merged
Conversation
daynew
force-pushed
the
fnd-1969-hide-old-cookie-banner
branch
from
September 10, 2022 00:55
375b7a8 to
c22a839
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we display a banner at the bottom of the page to users in GDPR countries which tells them about our cookie / tracking policy. However, this banner is not GDPR compliant. We now have a GDPR compliant banner built by OneTrust which we want to display instead of the non-compliant banner. This PR hides the old banner whenever we have the
onetrust_cookie_scriptsexperiment enabled.onetrust_cookie_scriptsexperiment is enabled.onetrust_cookie_scriptsexperiment is enabled.experiments.rbwhich makes it easier to hide/enable features using URL params or browser cookies (for testing purposes).Screenshot
Observe the One Trust cookie banner at the top of the screen:

Links
Testing story
Deployment strategy
Follow-up work