Skip to content

Hiding old cookie banner if new banner is shown - #48044

Merged
daynew merged 1 commit into
stagingfrom
fnd-1969-hide-old-cookie-banner
Sep 13, 2022
Merged

Hiding old cookie banner if new banner is shown#48044
daynew merged 1 commit into
stagingfrom
fnd-1969-hide-old-cookie-banner

Conversation

@daynew

@daynew daynew commented Sep 10, 2022

Copy link
Copy Markdown
Member

Right now, we display a banner at the bottom of the page to users in GDPR countries which tells them about our cookie / tracking policy. However, this banner is not GDPR compliant. We now have a GDPR compliant banner built by OneTrust which we want to display instead of the non-compliant banner. This PR hides the old banner whenever we have the onetrust_cookie_scripts experiment enabled.

  • Hides the old cookie_banner.haml when the onetrust_cookie_scripts experiment is enabled.
  • Shows the new onetrust_cookie_scripts banner when the onetrust_cookie_scripts experiment is enabled.
  • Adds experiments.rb which makes it easier to hide/enable features using URL params or browser cookies (for testing purposes).

Screenshot

Observe the One Trust cookie banner at the top of the screen:
image

Links

Testing story

Deployment strategy

  • This will be deployed to production hidden behind a DCDO experiment flag. We will do a bug bash using browser cookies. Once it seems like there are no issues, we will enable the DCDO experiment flag.

Follow-up work

  • Schedule a bug bash

@daynew
daynew requested a review from a team September 10, 2022 00:54
@daynew
daynew force-pushed the fnd-1969-hide-old-cookie-banner branch from 375b7a8 to c22a839 Compare September 10, 2022 00:55
@daynew
daynew requested a review from wilkie September 13, 2022 00:16

@wilkie wilkie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@daynew
daynew merged commit 30f8d36 into staging Sep 13, 2022
@daynew
daynew deleted the fnd-1969-hide-old-cookie-banner branch September 13, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants