Storybook Refactor - ConfirmEnableMakerDialog and ValidationStep - #48043
Merged
Conversation
epeach
changed the title
maddiedierker
approved these changes
Sep 12, 2022
maddiedierker
left a comment
maddiedierker
left a comment
Contributor
There was a problem hiding this comment.
small nit, but once that's addressed this is good to merge!
| ); | ||
| }); | ||
| export default { | ||
| title: 'MakerToolkit/ConfirmEnableMakerDialog', |
Contributor
There was a problem hiding this comment.
i'd remove the MakerToolkit/ prefix from this title -- it generates a new section in our storybook (shown in your screenshot), and we haven't really been organizing storybook files in sections, so i'd remove it for now. (although we should definitely organize our storybook into some sort of cohesive organization structure in the future!)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the effort to modernize our Storybook stories. Spreadsheet: https://docs.google.com/spreadsheets/d/1z8r10AcR0v3GimV_-28dJ6QaiaQ3CJoo9yXqa7U_bKs/edit#gid=0
This PR tackles both
ValidationStep.jsxandConfirmEnableMakerDialog.jsx.Screenshots of final product:
