Delete discountcode page and components - #48042
Merged
Merged
Conversation
epeach
changed the title
bencodeorg
approved these changes
Sep 12, 2022
bencodeorg
left a comment
bencodeorg
left a comment
Contributor
There was a problem hiding this comment.
🧹 🧹 🧹
One note on the Rails follow-up -- you also probably want to look into deleting the CircuitPlaygroundDiscountApplication model/table as well.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the storybook refactor, I encountered this code from an old program where we subsidized the cost of Circuit Playground kits. Discussion here: https://codedotorg.slack.com/archives/C1B3PNDL7/p1662757724965329. We no longer run this program so I deleted the page and components surrounding it.
studio.code.org/maker/discount will now 'sad-bee' when it's hit. From a data POV, from today back to 9/2/2021, this page was hit 3 times. From today back to 9/2/2020, this page was hit 49 times. (Per Google Analytics).
Follow-up work:
Delete
circuit_playground_discount_codes.rb