Skip to content

DTT (Staging > Test) [robo-dtt] - #48041

Merged
deploy-code-org merged 3 commits into
testfrom
staging
Sep 9, 2022
Merged

DTT (Staging > Test) [robo-dtt]#48041
deploy-code-org merged 3 commits into
testfrom
staging

Conversation

@deploy-code-org

Copy link
Copy Markdown
Contributor

No description provided.

Quoting from the documentation ([docs.rubocop.org](https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsblank), [rubydoc.info](https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/Blank)):

> Checks for code that can be written with simpler conditionals using `Object#blank?` defined by Active Support.

There is certainly an argument to be made that there are situations in which `!foo.present?` and `something unless foo.present?` can be more readable than `foo.blank?` and `something if foo.blank?`, depending on the specific variable names involved, but I think they're rare enough that the consistency we gain by enabling this rule is worth it.
Fix Violations of and Reenable `Rails/Blank`
@deploy-code-org
deploy-code-org merged commit cbad6bd into test Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants