Skip to content

Storybook migrations - ImportProjectDialog, SignInOrAgeDialog, UploadErrorDialog - #48039

Merged
fisher-alice merged 1 commit into
stagingfrom
storybook1
Sep 12, 2022
Merged

Storybook migrations - ImportProjectDialog, SignInOrAgeDialog, UploadErrorDialog#48039
fisher-alice merged 1 commit into
stagingfrom
storybook1

Conversation

@fisher-alice

@fisher-alice fisher-alice commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Migrated to new Storybook API:

  • ImportProjectDialog
  • SignInOrAgeDialog
  • UploadErrorDialog

Video of 3 components in Storybook:

storybook1.mp4

Links

Refer to this PR for context.
This spreadsheet keeps track of all migrations.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@fisher-alice
fisher-alice marked this pull request as ready for review September 9, 2022 22:15
}
]);
export default {
title: 'UploadErrorDialog',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep the directory structure here - Weblab/dialogs/UploadErrorDialog. That adds 'chapters' to the storybook that helps group features. Example screenshot of how it looks for MakerToolkit.
Screenshot from 2022-09-12 09-43-54

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind! Ignore this! Maddie just let me know we are dropping this organization practice! Sorry for the false alarm!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking on this!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you, erin! i would like us to use this organization structure in the future, but the way we have it currently is haphazard and doesn't really make any sense, so i think we do away with it for now since it's easy to do in the future

@epeach epeach left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants