Storybook migrations - ImportProjectDialog, SignInOrAgeDialog, UploadErrorDialog - #48039
Merged
Conversation
fisher-alice
marked this pull request as ready for review
September 9, 2022 22:15
fisher-alice
requested review from
a team,
maddiedierker and
sanchitmalhotra126
September 9, 2022 22:15
epeach
reviewed
Sep 12, 2022
| } | ||
| ]); | ||
| export default { | ||
| title: 'UploadErrorDialog', |
There was a problem hiding this comment.
Nevermind! Ignore this! Maddie just let me know we are dropping this organization practice! Sorry for the false alarm!
Contributor
Author
There was a problem hiding this comment.
Thanks for checking on this!
Contributor
There was a problem hiding this comment.
+1, thank you, erin! i would like us to use this organization structure in the future, but the way we have it currently is haphazard and doesn't really make any sense, so i think we do away with it for now since it's easy to do in the future
maddiedierker
approved these changes
Sep 12, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migrated to new Storybook API:
Video of 3 components in Storybook:
storybook1.mp4
Links
Refer to this PR for context.
This spreadsheet keeps track of all migrations.
PR Checklist: