Skip to content

HoC.com - FAQ updates - #48031

Merged
kelbyhawn merged 5 commits into
stagingfrom
hoc-faq-changes
Sep 15, 2022
Merged

HoC.com - FAQ updates#48031
kelbyhawn merged 5 commits into
stagingfrom
hoc-faq-changes

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Sep 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Improve the UX of the FAQs on hourofcode.com:

  • Remove the FAQs from the bottom of the homepage and create a standalone FAQs page
  • Make each FAQ an accordion using pure HTML/CSS for better readability and accessiblity

Relevant info: Asana task

Before

Was an anchor link at the bottom of the homepage:
Screen Shot 2022-09-09 at 9 57 16 AM

After

Moved to its own page w/ accordians:
Screen Shot 2022-09-09 at 9 55 51 AM

@kelbyhawn
kelbyhawn requested review from a team and breville September 14, 2022 16:25
@breville

breville commented Sep 14, 2022

Copy link
Copy Markdown
Member

Just a note that I was able to pull this locally and see the the FAQ in Spanish with https://hourofcode.com:3000/us/es/faq which is good.

One super nit is that you could add user-select: none for the <summary> tags so that a pair of clicks to expand/contract a heading doesn't also do a double-click which is probably not intended in that case.

@kelbyhawn
kelbyhawn merged commit e5115b4 into staging Sep 15, 2022
@kelbyhawn
kelbyhawn deleted the hoc-faq-changes branch September 15, 2022 17:30
@sanchitmalhotra126 sanchitmalhotra126 mentioned this pull request Sep 16, 2022
Merged
8 tasks
@kelbyhawn kelbyhawn added the hoc label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes
@breville breville Awaiting requested review from breville

Assignees

No one assigned

Labels

hoc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kelbyhawn @breville @bethanyaconnor