Skip to content

Add new modules to CS Connections landing page - #48023

Merged
kelbyhawn merged 4 commits into
stagingfrom
mktg-csconnections-page-updates
Sep 12, 2022
Merged

Add new modules to CS Connections landing page#48023
kelbyhawn merged 4 commits into
stagingfrom
mktg-csconnections-page-updates

Conversation

@kelbyhawn

@kelbyhawn kelbyhawn commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Updates to https://code.org/educate/csc:

  • Add four new modules to the Modules section under the Poem Art box
  • Add a "Feedback" section that links to a Google Form
  • Change h2s: Open-ended projects > Sample Projects & Bridging Lessons > Quick Activities
  • Remove images and add "Sample" to each title in the Sample Projects section

Relevant info: Asana taskGdoc w/ details


Before:

Screen Shot 2022-09-08 at 3 57 51 PM

Screen Shot 2022-09-08 at 3 57 38 PM

After:

Screen Shot 2022-09-08 at 3 58 06 PM

Screen Shot 2022-09-08 at 3 57 12 PM

@kelbyhawn
kelbyhawn requested review from a team and dju90 September 9, 2022 15:41
padding: 0 1.5em 1.5em;
}

h3{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: should there be a space here (same for a.btn below)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes! Good catch 😄


a {
font-family: 'Gotham 4r', sans-serif;
color: $color-black !important;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need important here and below? (we definitely might just curious why!)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was leftover from my earlier refactor process — just tried it without and we don't need them! ✨


## Open-ended projects
{{ csc_module, title: "Marine Life Ecosystems", image: "/images/csc/landing/module_marine_life.png", grades: "3-5", subject: "Science", duration: "4 hours", description: "Restore balance to a marine life ecosystem on the verge of overfishing.", button_text: "Learn more", url: "https://studio.code.org/s/csc-ecosystems-2022" }}
{{ csc_module, title: "Star Quilts", grades: "3-5", image: "/images/csc/landing/module_star_quilts.png", subject: "Math", duration: "4 hours", description: "Design a Native American star quilt using rhombus patterns in The Artist.", button_text: "Learn more", url: "https://studio.code.org/s/csc-starquilts-2022" }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another tiny nit (sorry!): can we keep the properties in the same order? so grades after image here to be consistent with the others? I thought grades wasn't set on this one at first

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to apologize, I love it! Just updated.

@bethanyaconnor bethanyaconnor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny nits and a question but otherwise lgtm!

@kelbyhawn
kelbyhawn merged commit a70c222 into staging Sep 12, 2022
@kelbyhawn
kelbyhawn deleted the mktg-csconnections-page-updates branch September 12, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants