Skip to content

Revert "Revert "Upgrade to webpack 5"" - #48021

Merged
maddiedierker merged 3 commits into
stagingfrom
revert-48020-revert-47093-webpack-5-upgrade
Sep 14, 2022
Merged

Revert "Revert "Upgrade to webpack 5""#48021
maddiedierker merged 3 commits into
stagingfrom
revert-48020-revert-47093-webpack-5-upgrade

Conversation

@maddiedierker

@maddiedierker maddiedierker commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

Reverts #48020, re-introducing the Webpack 5 upgrade.

The upgrade was reverted because UI/Eyes tests were failing in the DTT -- I believe I've tracked down all of the failures to malformed URLs generated by CopyPlugin (which is also being upgraded). Those URLs are fixed in ff0e257 and 2027cd2. More details on this issue in #48017.

Description from original upgrade PR (#47093):


Builds on changes in #41990 and #46108, minus migration to dart-sass since that was shipped in #46235.

Upgrades our apps package from Webpack v4 to v5, along with upgrading related dependencies. See some notes taken throughout the process in this doc.

Most notably, we now have to supply our own Node polyfills. Webpack <= 4 automatically polyfilled Node libraries. With this upgrade, we now have to supply packages for the Node libraries we depend on. See nodePolyfillConfig in apps/webpack.js, webpack resolve.fallback docs, and Webpack 5 Node Polyfills Upgrade Cheatsheet for more details.

Other notable changes in this PR:

  • I had to increase max_old_space_size from 4096 to 5120 (for production build scripts only).
  • Regression tests in Applab/Gamelab ExporterTest.js files get stuck in an infinite loop. The unit tests that cover this functionality pass and I've tested exports in both labs, so I've skipped these tests for now and will revisit in STAR-2399.

@maddiedierker
maddiedierker force-pushed the revert-48020-revert-47093-webpack-5-upgrade branch from 484e147 to 2027cd2 Compare September 10, 2022 00:08
@maddiedierker
maddiedierker requested a review from a team September 12, 2022 17:24
@maddiedierker
maddiedierker merged commit 9ac806f into staging Sep 14, 2022
@maddiedierker
maddiedierker deleted the revert-48020-revert-47093-webpack-5-upgrade branch September 14, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant