Remove extra / from locale paths - #48017
Merged
Merged
Conversation
This was referenced Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging #47093 (the webpack 5 upgrade), many UI/Eyes tests are failing in the DTT. This is a fix forward.
All the tests I investigated had errors like this:
where requests for locale files were 404ing. The URL for those locale files had an extra
/:Attempting to load that URL failed, but removing the extra
/successfully loaded the minified locale file. I updated the rule for locale files in our Gruntfile and tested locally that the URL was updated as expected using the "Using minified js locally" and "Using rails asset pipeline locally" documentation in build.md.