Fix Violations of and Reenable Rails/Blank - #48015
Merged
Merged
Conversation
Quoting from the documentation ([docs.rubocop.org](https://docs.rubocop.org/rubocop-rails/cops_rails.html#railsblank), [rubydoc.info](https://www.rubydoc.info/gems/rubocop-rails/RuboCop/Cop/Rails/Blank)): > Checks for code that can be written with simpler conditionals using `Object#blank?` defined by Active Support. There is certainly an argument to be made that there are situations in which `!foo.present?` and `something unless foo.present?` can be more readable than `foo.blank?` and `something if foo.blank?`, depending on the specific variable names involved, but I think they're rare enough that the consistency we gain by enabling this rule is worth it.
bethanyaconnor
approved these changes
Sep 8, 2022
pablo-code-org
approved these changes
Sep 9, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoting from the documentation (docs.rubocop.org, rubydoc.info):
There is certainly an argument to be made that there are situations in which
!foo.present?andsomething unless foo.present?can be more readable thanfoo.blank?andsomething if foo.blank?, depending on the specific variable names involved, but I think they're rare enough that the consistency we gain by enabling this rule is worth it.PR Checklist: