Re-add project backed freeplay level to uncached levels list - #48008

Bummer. Definitely would love to find a fix for this scenario (signed out users) before Hour of Code. Let me know if I can help with implementing tests that detect this issue in environments that don't use CloudFront (we have logic that implements HTTP caching in that fallback scenario).

Bummer. Definitely would love to find a fix for this scenario (signed out users) before Hour of Code. Let me know if I can help with implementing tests that detect this issue in environments that don't use CloudFront (we have logic that implements HTTP caching in that fallback scenario).

huge thanks to the infra team (past and present) for making the http caching rules work without cloudfront! My initial take is that this gives us the ability to iterate on a fix for this quickly in local development. I am not sure I see a way to add an automated test to catch this kind of problem, but it could be possible.

One saving grace is that the behavior of showing an error and reloading the page is pretty aggressive and user-visible, which means it is likely that users notice and report this kind of problem. this is a big step up from when we just silently let users continue editing only to find later that their work was lost. Based on that, I would argue that automated end-to-end testing of a fix for this is not 100% required.

I am not sure I see a way to add an automated test to catch this kind of problem, but it could be possible.

@sureshc if you believe this is possible then we'd love your help with it!

Also not sure how to write a test for this but happy to if I can get a pointer as to how. I'd like to merge this PR ASAP (unfortunately, Drone decided to start slowly on this PR so not quite as ASAP as I'd have liked) so it might be done in a follow up PR.

I did create a task to fix this: https://codedotorg.atlassian.net/browse/LP-2433

huge thanks to the infra team (past and present) for making the http caching rules work without cloudfront!

💯

unfortunately it looks like dashboard tests did not run in drone:

[test] Files affecting dashboard    tests unmodified from origin/staging. Skipping tests.

and now this test is failing in my drone runs:

==�[0m�[1000D�[K FAIL["test_dance_session_cookie_and_cache_headers", "RoutesTest", 367.90421924600014]
 test_dance_session_cookie_and_cache_headers#RoutesTest (367.90s)
        Expected /(^|,)\s*public\s*(,|$)/ to match "must-revalidate, no-store, private, max-age=0".
        test/test_helper.rb:330:in `block in assert_cache_control_match'
        test/test_helper.rb:329:in `each'
        test/test_helper.rb:329:in `assert_cache_control_match'
        test/test_helper.rb:349:in `assert_caching_enabled'
        test/integration/routes_test.rb:20:in `test_dance_session_cookie_and_cache_headers'
        test/testing/setup_all_and_teardown_all.rb:36:in `run'

@bethanyaconnor would you be willing to own the fix?

oh shoot, sorry didn't notice that. Yeah, I can own