Set Hour of Code Email Reply-To Field - #47996
Merged
Merged
Conversation
pablo-code-org
approved these changes
Sep 8, 2022
Hamms
reviewed
Sep 8, 2022
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| from: "Hadi Partovi (Code.org) <hadi_partovi@code.org>" | |||
| reply-to: hadi_partovi@code.org | |||
Contributor
There was a problem hiding this comment.
Shouldn't we use noreply@code.org here?
Contributor
Author
There was a problem hiding this comment.
Emails sent to hadi_partovi@code.org get routed to Support, which can be convenient for people to be able to get help.
Contributor
Author
There was a problem hiding this comment.
Maybe we can try this in two phases? First check whether specifying a reply-to improves delivery? And then switch to noreply?
Hamms
approved these changes
Sep 8, 2022
cat5inthecradle
approved these changes
Sep 8, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Mail (and possibly other email providers) are frequently classifying Hour of Code sign up email receipts as spam due to DKIM and DMARC failing. Account Sign Up and Password Reset emails are transmitted with much of the same code and the same AWS Simple Email Service configuration, but are typically passing DKIM and DMARC and are typically NOT being classified as spam.
After reviewing differences between the email headers between the two types of emails, speculatively set the
Reply-ToSMTP header in Hour of Code sign up email receipts.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: