Fix duplicate table issue when dashboard has contact_rollups table before pegasus - #47993
Merged
TurnerRiley merged 1 commit intoSep 15, 2022
Conversation
TurnerRiley
changed the title
davidsbailey
approved these changes
Sep 9, 2022
davidsbailey
left a comment
davidsbailey
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this, @TurnerRiley !
TurnerRiley
deleted the
prevent-duplicate-tables-136-pegasus-project-migration
branch
September 15, 2022 18:32
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In relation to this PR about pegasus migrations on project tables failing, other developers were having issues executing
rake installwithout hitting a similar error from136_drop_contact_rollups.rb. As stated in the PR above, this is "possibly because the tables are already created in dashboard by the time the pegasus migrations try to create the same tables."The solution is to swap
drop_tablefordrop_table?instead of commenting out the line (as in the fix in the slack thread above) so that other people don't run into the same problem when migrating tables.Links
Related PR about fix pegasus migrations on project tables failing: here
Slack threads: original thread and similar thread
Testing story
Just like the related PR, "drone runs all pegasus migrations, passing drone run is a good indicator that setting up new environments from scratch should continue to work."
PR Checklist: