Skip to content

hoc2022: Update test hoc_mode to pre-hoc - #47987

Merged
breville merged 1 commit into
stagingfrom
hoc2022-update-test-hoc-mode-to-pre-hoc
Sep 7, 2022
Merged

hoc2022: Update test hoc_mode to pre-hoc#47987
breville merged 1 commit into
stagingfrom
hoc2022-update-test-hoc-mode-to-pre-hoc

Conversation

@breville

@breville breville commented Sep 7, 2022

Copy link
Copy Markdown
Member

Update the test environment's hoc_mode to "pre-hoc".

@breville
hoc2022: Update test hoc_mode to pre-hoc
3a63024 
Update the test environment's hoc_mode to "pre-hoc".
@breville
breville requested review from a team, Hamms and kelbyhawn September 7, 2022 21:37
@Hamms

Hamms commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Presumably we'll have to make the same update in the other direction after we've switched our other servers back to post-hoc; anything we should do now to make that easier?

@breville

breville commented Sep 7, 2022

Copy link
Copy Markdown
Member Author

Presumably we'll have to make the same update in the other direction after we've switched our other servers back to post-hoc; anything we should do now to make that easier?

It's a good question. We might flip this through soon-hoc and actual-hoc as well before we reach post-hoc again. The real cost of this change is updating our Eyes baselines for relevant site changes through each of these flips, which is partly why we don't always flip it through all of them, though it's usually a judgement call at each step.

Offhand, I'm not sure the best way to improve this...

Hamms
Hamms approved these changes Sep 7, 2022
View reviewed changes

@Hamms Hamms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, right. That makes sense, and it definitely seems worth our while to do something to make this a bit less manual in the long run, since this is a dance we have to do every year. But this LGTM for now!

@breville
breville merged commit 5d3f47b into staging Sep 7, 2022
@breville
breville deleted the hoc2022-update-test-hoc-mode-to-pre-hoc branch September 7, 2022 23:26
@bencodeorg bencodeorg mentioned this pull request Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hamms Hamms Hamms approved these changes
@kelbyhawn kelbyhawn kelbyhawn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@breville @Hamms @kelbyhawn