turn all pegasus migrations on project tables into no-ops - #47983
Merged
Conversation
davidsbailey
force-pushed
the
noop-pegasus-project-migrations
branch
from
September 7, 2022 20:40
3c99cc2 to
0f2cc1a
Compare
8 tasks
davidsbailey
marked this pull request as ready for review
September 8, 2022 04:52
davidsbailey
requested review from
a team,
TurnerRiley and
bethanyaconnor
and removed request for
a team
September 8, 2022 04:56
bethanyaconnor
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike dashboard, all previous pegasus migrations will be run when a developer is setting up a new system. some developers have been running into problems with the projects tables in pegasus (storage_apps and user_storage_ids), sometimes because the tables are already created in dashboard by the time the pegasus migrations try to create the same tables.
the solution is to remove all mention of pegasus projects tables from pegasus migrations. you can see from the history of some of the other
nopmigrations how we have done this in the past.Testing story
drone runs all pegasus migrations. passing drone run is a good indicator that setting up new environments from scratch should continue to work. some developers running migrations on machines that are months out of date may end up not removing certain tables from pegasus DB, but that should be mostly harmless.