Delete all remaining code_review_comment code - #47977
Merged
Merged
Conversation
…review_comments_code
sanchitmalhotra126
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code_review_commentswas replaced bycode_review_notesin v2. We are going to drop thecode_review_commentstable in a follow-up pr to this one. I am doing all the code deletion here because migrations happen before code updates in our deploy system, so doing the code delete first will avoid any unexpected errors.. The last row in the table was created on 6/22/22, which was when we switched over to v2.Links
Testing story
Tested that code review still works after this change.
Follow-up work
Do a drop table migration for this table after this change has been deployed.