Skip to content

adding "add New Animation..." raw string to i18n - #47970

Merged
mgc1194 merged 1 commit into
stagingfrom
fnd-2078-add-new-animmation-to-i18n
Sep 7, 2022
Merged

adding "add New Animation..." raw string to i18n#47970
mgc1194 merged 1 commit into
stagingfrom
fnd-2078-add-new-animmation-to-i18n

Conversation

@mgc1194

@mgc1194 mgc1194 commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

What: Adding "Add a new animation on the left to begin" raw string from AnimationTab.jsx to the i18n pipeline.
Why: Game Lab uses animations, when there is no animation added to the project, a message is displayed. This message was coded as a raw string and needed to be included in the i18n sync.

Links

Testing story

testing messages shows correctly on screen.
Screen Shot 2022-08-31 at 21 09 06

@mgc1194
mgc1194 requested a review from a team as a code owner September 7, 2022 11:14

@smusoke smusoke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@wilkie wilkie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgc1194
mgc1194 merged commit a4baf92 into staging Sep 7, 2022
@mgc1194
mgc1194 deleted the fnd-2078-add-new-animmation-to-i18n branch September 7, 2022 18:22
@mgc1194 mgc1194 added the translate-csd Has to do with the CSD localization epic! label Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translate-csd Has to do with the CSD localization epic!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants