Google Blockly: place trashcan correctly in RTL languages - #47964
Merged
Conversation
I agree! Can we track this as task in Jira so we don't forget? |
Contributor
Author
Can do! Item here: https://codedotorg.atlassian.net/browse/STAR-2403 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the container for the trashcan in Google Blockly to be positioned appropriately (ie, in place of toolbox) in right-to-left languages.
It feels like a better solution would be to render the trashcan as a child of the toolbox SVG element (rather than having to keep track of positioning it at the same location as the toolbox)? Not sure if there's a reason we don't do that already, but didn't feel comfortable making larger changes like that when I don't totally have my Blockly bearings yet :).
Before
After
Links
Testing story
Tested manually on a level that has a "flyout" but no toolbox (s/poem-art-2021/lessons/1/levels/1) and one that has both a flyout and a toolbox (/s/dance-2019/lessons/1/levels/10?blocklyVersion=Google), and saw the trashcan appearing in the correct location (centered within the flyout in the poem art case, and within the toolbox in the dance party case). Confirmed that trash can continued to appear in correct location in English as well on each of these levels.