remove unused /v2/poste/send-message route from pegasus - #47925
Merged
Conversation
davidsbailey
marked this pull request as ready for review
September 2, 2022 06:08
davidsbailey
changed the title
pablo-code-org
approved these changes
Sep 9, 2022
pablo-code-org
left a comment
pablo-code-org
left a comment
Contributor
There was a problem hiding this comment.
Talked to the team, and we all agree it is good.
Member
Author
|
excellent, thanks so much @pablo-code-org for all your help with reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the things marked for removal in https://docs.google.com/spreadsheets/d/1-qAM-vMnc5PZXIJSiIArZGGWTQTiDbepQUXR5ZBxvB4/edit#gid=0 is the /v2/poste/send-message route. This PR removes that route.
this is just speculation, but I suspect this route may be left over from when we used to send batches of marketing emails through poste. now we send those marketing emails through pardot.
Testing story