Skip to content

Remove Unnecessary lock_thread Argument - #47857

Merged
Hamms merged 1 commit into
stagingfrom
remove-unnecessary-lock_thread
Sep 7, 2022
Merged

Remove Unnecessary lock_thread Argument#47857
Hamms merged 1 commit into
stagingfrom
remove-unnecessary-lock_thread

Conversation

@Hamms

@Hamms Hamms commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Rails 6.1 changed this method to no longer accept a catchall options object and to instead use specific keyword arguments.

This change reveals that we have been passing a keyword argument which is not actually used, so in this PR we stop passing it.

Links

Testing story

Relying on existing unit tests to verify that this does not represent any change in functionality

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Rails 6.1 (specifically, rails/rails#36478) changed this method to no longer accept a catchall options object and to instead use specific keyword arguments.

This change reveals that we have been passing a keyword argument which is not actually used, so in this PR we stop passing it.
@Hamms Hamms added the Rails Upgrade All work related to upgrading the version of Ruby on Rails we use. label Aug 29, 2022
@Hamms
Hamms requested a review from a team August 30, 2022 20:30
@Hamms
Hamms merged commit fea6320 into staging Sep 7, 2022
@Hamms
Hamms deleted the remove-unnecessary-lock_thread branch September 7, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rails Upgrade All work related to upgrading the version of Ruby on Rails we use.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants