Skip to content

add string for displaying number of projects created in millions - #47754

Merged
davidsbailey merged 1 commit into
stagingfrom
million-projects-created-string
Aug 24, 2022
Merged

add string for displaying number of projects created in millions#47754
davidsbailey merged 1 commit into
stagingfrom
million-projects-created-string

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Aug 22, 2022

Copy link
Copy Markdown
Member

Similar to #47752, we want to remove this access to pegasus DB:

in order to do that, the plan is to change this user-facing string:

Screen Shot 2022-08-23 at 2 57 41 PM

the new string will say "Over 200 million projects created" (see slack for discussion).

Unlike the previous PR, the new string is different enough that we need to introduce the new string first, then wait for it to be translated, before we can update the code to use the new string. So, all this PR does is add the new string.

Follow-up work

Wait for 2-3 weeks (translation syncs), then update studio.code.org/projects to use the new string.

@davidsbailey
davidsbailey marked this pull request as ready for review August 23, 2022 22:04
@davidsbailey
davidsbailey requested a review from a team as a code owner August 23, 2022 22:04
@davidsbailey
davidsbailey requested review from a team and removed request for a team August 23, 2022 22:05

@megcrenshaw megcrenshaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom!

@davidsbailey
davidsbailey merged commit 4104ad3 into staging Aug 24, 2022
@davidsbailey
davidsbailey deleted the million-projects-created-string branch August 24, 2022 02:58
@davidsbailey

Copy link
Copy Markdown
Member Author

note to self: translated into 2 languages as of #48024

@davidsbailey

Copy link
Copy Markdown
Member Author

now translated into 34 languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants