Skip to content

show approximate number of students who have learned on code.org - #47752

Merged
davidsbailey merged 2 commits into
stagingfrom
over-n-million-students
Aug 23, 2022
Merged

show approximate number of students who have learned on code.org#47752
davidsbailey merged 2 commits into
stagingfrom
over-n-million-students

Conversation

@davidsbailey

@davidsbailey davidsbailey commented Aug 22, 2022

Copy link
Copy Markdown
Member

As part of Milestone 1 of Separating Pegasus, we need to eliminate places where dashboard code accesses pegasus DB.

The purpose of this PR is to remove the following pegasus DB accesses from dashboard:

See screenshots below for user-visible changes on https://studio.code.org/courses as a result of hard-coding the number of students. The marketing team has agreed to these changes (see slack), and will own asking for this number to be updated whenever the number of students reaches the next multiple of 10M.

Also, there is no visible change associated with removing the fetch for lines_of_code, presumably because it was removed from the UI in a previous PR.

Screenshots

student

Screen Shot 2022-08-22 at 11 00 17 AM

signed out

Screen Shot 2022-08-22 at 10 59 26 AM

teacher

The teacher view for /courses is unchanged:

Screen Shot 2022-08-17 at 3 24 54 PM

Testing story

Deployment strategy

normally we have to be careful about deploying translatable string changes, however in this case the new string text seems backward compatible enough, i.e. it seems ok that it will say "70M students learned" instead of "Over 70M..." or "73M students learned" for a short period of time. so I am just planning to merge the string change and the code change as part of the same PR, rather than creating a whole separate string and then waiting for it to be translated.

Follow-up work

ideally this would not need to be updated manually in the future. the work to figure out how to share this kind of data between dashboard and pegasus will be tracked as part of the ongoing effort to separate pegasus from dashboard.

@davidsbailey
davidsbailey marked this pull request as ready for review August 23, 2022 15:27
@davidsbailey
davidsbailey requested a review from a team as a code owner August 23, 2022 15:27
@davidsbailey
davidsbailey requested review from a team and removed request for a team August 23, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants