show approximate number of students who have learned on code.org - #47752
Merged
Conversation
This was referenced Aug 22, 2022
davidsbailey
marked this pull request as ready for review
August 23, 2022 15:27
dmcavoy
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of Milestone 1 of Separating Pegasus, we need to eliminate places where dashboard code accesses pegasus DB.
The purpose of this PR is to remove the following pegasus DB accesses from dashboard:
code-dot-org/dashboard/app/views/courses/index.html.haml
Line 2 in a23aa45
code-dot-org/dashboard/app/views/courses/index.html.haml
Line 4 in a23aa45
See screenshots below for user-visible changes on https://studio.code.org/courses as a result of hard-coding the number of students. The marketing team has agreed to these changes (see slack), and will own asking for this number to be updated whenever the number of students reaches the next multiple of 10M.
Also, there is no visible change associated with removing the fetch for
lines_of_code, presumably because it was removed from the UI in a previous PR.Screenshots
student
signed out
teacher
The teacher view for /courses is unchanged:
Testing story
Deployment strategy
normally we have to be careful about deploying translatable string changes, however in this case the new string text seems backward compatible enough, i.e. it seems ok that it will say "70M students learned" instead of "Over 70M..." or "73M students learned" for a short period of time. so I am just planning to merge the string change and the code change as part of the same PR, rather than creating a whole separate string and then waiting for it to be translated.
Follow-up work
ideally this would not need to be updated manually in the future. the work to figure out how to share this kind of data between dashboard and pegasus will be tracked as part of the ongoing effort to separate pegasus from dashboard.