Update activerecord-import Gem - #47703
Merged
Merged
Conversation
To pick up support for Rails 6.1, which [was added in 1.0.3](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md#changes-in-103)
Hamms
added
the
Rails Upgrade
Hamms
marked this pull request as ready for review
August 29, 2022 19:36
bethanyaconnor
approved these changes
Aug 30, 2022
bethanyaconnor
left a comment
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
This seems reasonable but I'd also recommend watching Honeybadger closely after this change is deployed. We should see any issues that aren't caught by CI pretty quickly there
This was referenced Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To pick up support for Rails 6.1, which was added in 1.0.3
The only breaking change listed between these versions is a change to make
on_duplicate_key_updateno longer enabled by default in MySQL. We're using MySQL so this change could impact us, but as far as I've been able to find we are usually consistent about setting this value explicitly:code-dot-org/dashboard/lib/services/script_seed.rb
Line 406 in b9e87de
code-dot-org/dashboard/lib/services/script_seed.rb
Line 265 in b9e87de
code-dot-org/dashboard/lib/level_loader.rb
Line 73 in b9e87de
But there are some situations in which we don't:
code-dot-org/dashboard/lib/level_loader.rb
Line 49 in b9e87de
code-dot-org/dashboard/lib/mega_section.rb
Line 127 in 08acc05
code-dot-org/dashboard/app/models/video.rb
Line 55 in 08acc05
In those situations, the old behavior would be that any entries with duplicate unique identifiers would be combined. The new behavior is that an error will be raised.
My expectation is that if there is anywhere that we are relying on old behavior, that will be revealed by our continuous integration system.
Links
Testing story
Relying on existing tests to verify that this does not result in any change in behavior.
PR Checklist: