Use new weblab share url and redirect old one - #47421
Conversation
f2249a4 to
62170f6
Compare
davidsbailey
left a comment
davidsbailey
left a comment
There was a problem hiding this comment.
Looks good after addressing one comment. I didn't see any mention of codeprojects in our UI tests. can say what you did to test this end-to-end before merging?
| pass unless valid_encrypted_channel_id(encrypted_channel_id) | ||
|
|
||
| get_file('files', encrypted_channel_id, filename, true) | ||
| redirect "/projects/weblab#{request.path_info}" |
There was a problem hiding this comment.
now this route looks like a duplicate of the route on line 205. if this change is intentional, perhaps this route can just be removed? if you want to keep it, I think it would be helpful to include an example of the route you are trying to match in the comments.
There was a problem hiding this comment.
Good call! I deduplicated them
It turns out that codeprojects doesn't work outside of production and development, so there aren't any tests for it (Suresh actually helped me set it up for development a few months ago so before then it was production only). I tested everything locally by going to localhost.codeproject.org:3000/, etc and confirming that I was seeing the correct behavior. |
this works for me! |
2 participants
This is a fairly long overdue follow up to launching codeprojects on dashboard. As part of that change, we moved codeprojects share URLs to be in the pattern of /projects/weblab/ instead of just /. This PR redirects the old version of the URL to the new one as well as surfacing the new format in the share dialog.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: