You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
NOTE for future table renames: dashboard table renames will cause shared tests in the test environment to fail due to the new table not existing in dashboard_test1. We use dashboard_test1 for pegasus/lib etc tests so that it doesn’t muddy up dashboard_test which is used for UI tests. However, dashboard_test1 (through dashboard_test16) are setup by the step that runs dashboard unit tests. In order for dashboard_test1-16 to be migrated, dashboard tests need to be manually run in test first. Once dashboard tests have been manually run in the test env, restart the test build.
Rename db table project_versions to project_commits and update references to the table.
The rename migration also includes the creation of a db view with the old table name so that in the time between when the migration is run and the app code deploys the code referencing the old table name will still return data
maureensturgeon
changed the title
Rename project_versions table to project_commits, update references
Rename project_versions table to project_commits
Jul 5, 2022
Is usage low enough that we could carry out a standard Rails migration? There would be a ~40 minute period of time between when the migration executions on production-daemon and when the new web application servers launch that the web servers would be querying the old table name. Perhaps that’s acceptable at this time of the year.
Is usage low enough that we could carry out a standard Rails migration? There would be a ~40 minute period of time between when the migration executions on production-daemon and when the new web application servers launch that the web servers would be querying the old table name. Perhaps that’s acceptable at this time of the year.
I retract my above comment! Provisioning a View to provide backwards compatibility for ~40 minutes does not add much complexity and guarantees an uninterrupted experience for students!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE for future table renames: dashboard table renames will cause shared tests in the test environment to fail due to the new table not existing in
dashboard_test1. We use dashboard_test1 for pegasus/lib etc tests so that it doesn’t muddy up dashboard_test which is used for UI tests. However, dashboard_test1 (through dashboard_test16) are setup by the step that runs dashboard unit tests. In order for dashboard_test1-16 to be migrated, dashboard tests need to be manually run in test first. Once dashboard tests have been manually run in the test env, restart the test build.More context in #47038
Rename db table
project_versionstoproject_commitsand update references to the table.The rename migration also includes the creation of a db view with the old table name so that in the time between when the migration is run and the app code deploys the code referencing the old table name will still return data
Links
Testing
PR Checklist: