Change references from project versions to project commits - #47038
Merged
Conversation
maureensturgeon
marked this pull request as ready for review
June 30, 2022 23:08
molly-moen
approved these changes
Jun 30, 2022
bethanyaconnor
approved these changes
Jul 1, 2022
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
project_versionstable stores the data of a commit for a project, it's not currently used for anything else. When I was working on code review v2, I found the nameproject_versionsconfusing because not all version of the project are stored in the table, only the project versions associated with commits are stored in the table. The proposal is to change the table namedproject_versionstoproject_commitsto more clearly signify the content and intent of the table.The first step of this process in this PR is to change all references to the the term "project version" to "project commit" where that's what we mean, but not change the underlying DB name, so rename the model, controller, etc. The next step will be to do the actual name migration which is outlined in the "Follow-up work" below.
Links
Testing story
Follow-up work
The next piece of this work is the DB table rename. The plan is to follow a similar pattern as what was done for the storage_apps => projects table rename (#45476). I'll write a migration that renames the table and creates a temporary view with the old table name so that during the time between the when the migration is run and when the new code is deployed that data will continue to be served.
PR Checklist: