Skip to content

Change references from project versions to project commits - #47038

Merged
maureensturgeon merged 1 commit into
stagingfrom
maureen/LP-2415-rename-project-versions
Jul 1, 2022
Merged

Change references from project versions to project commits#47038
maureensturgeon merged 1 commit into
stagingfrom
maureen/LP-2415-rename-project-versions

Conversation

@maureensturgeon

@maureensturgeon maureensturgeon commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Currently the project_versions table stores the data of a commit for a project, it's not currently used for anything else. When I was working on code review v2, I found the name project_versions confusing because not all version of the project are stored in the table, only the project versions associated with commits are stored in the table. The proposal is to change the table named project_versions to project_commits to more clearly signify the content and intent of the table.

The first step of this process in this PR is to change all references to the the term "project version" to "project commit" where that's what we mean, but not change the underlying DB name, so rename the model, controller, etc. The next step will be to do the actual name migration which is outlined in the "Follow-up work" below.

Links

Testing story

  • Create a commit locally
  • Load commits locally
  • Log in as teacher/peer and see commits for another user

Follow-up work

The next piece of this work is the DB table rename. The plan is to follow a similar pattern as what was done for the storage_apps => projects table rename (#45476). I'll write a migration that renames the table and creates a temporary view with the old table name so that during the time between the when the migration is run and when the new code is deployed that data will continue to be served.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maureensturgeon maureensturgeon changed the title rename project version to project commits, except table rename Change references to project versions to project commits Jun 29, 2022
@maureensturgeon maureensturgeon changed the title Change references to project versions to project commits Change references from project versions to project commits Jun 30, 2022
@maureensturgeon
maureensturgeon marked this pull request as ready for review June 30, 2022 23:08
@maureensturgeon
maureensturgeon requested review from a team June 30, 2022 23:08
@maureensturgeon
maureensturgeon merged commit 9ebf746 into staging Jul 1, 2022
@maureensturgeon
maureensturgeon deleted the maureen/LP-2415-rename-project-versions branch July 1, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants