Cache dance party freeplay level - #46857
Merged
Merged
Conversation
jamescodeorg
commented
Jun 14, 2022
| it 'Strips cookies from the penultimate dance level' do | ||
| assert strips_session_specific_cookies_from_request? '/s/dance/lessons/1/levels/12' | ||
| assert strips_session_specific_cookies_from_request? '/s/dance-2019/lessons/1/levels/9' | ||
| it 'Strips cookies from dance levels' do |
Contributor
Author
There was a problem hiding this comment.
I was unable to verify these tests locally and Drone may not run them either so DTT may be the first place these will be run. I will keep an eye on the pipeline after I merge.
| end | ||
|
|
||
| it 'Strips cookies from the penultimate dance level' do | ||
| assert strips_session_specific_cookies_from_request? '/s/dance/lessons/1/levels/12' |
Contributor
There was a problem hiding this comment.
We lost this /dance/ (not 2019) test, no longer needed?
Contributor
Author
There was a problem hiding this comment.
There are lots of scripts and levels that we cache (and strip cookies from) so I changed this test to more of a spot check that some arbitrary levels in an arbitrary cached script behaves as expected.
maureensturgeon
approved these changes
Jun 15, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing off the work to cache all free play levels that was started here.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: