Replace "color" import with "color.scss" - #46365
Merged
Merged
Conversation
megcrenshaw
approved these changes
May 16, 2022
megcrenshaw
left a comment
megcrenshaw
left a comment
There was a problem hiding this comment.
Worked perfectly for me! Thanks, Tim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all instances of
@import "color"with@import "color.scss"(single and double quotes) to preserve consistency and prevent build errors due to dart-sass upgrade.This skips the 'dashboard/app/assets' directory, since that was giving style warnings (these files were not causing build issues):
/home/objelisks/code-dot-org/dashboard/app/assets/stylesheets/application.scss:31:9 [W] ImportPath: Imported partial 'color.scss' should be written as 'color'Still unsure of the root cause here. Only a subset of these files actually cause issues at build time, but I'm replacing all of them in order to keep some consistency. It is only color.scss that ever causes any problems. The only thing special about that file that I can find is that we run
convertScssToJs.json that file, but that doesn't look like it would affect anything about the import.Links
Testing story
ran
yarn buildyarn storybookandyarn test