Dart-sass migration - #46235
Merged
Merged
Conversation
…ut bumping webpack also)
jamescodeorg
approved these changes
May 6, 2022
jamescodeorg
left a comment
jamescodeorg
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Could you just add a note about why we decided to move to dart-sass in the PR comments? Thanks for taking care of this!
Merged
This was referenced Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits out the dart-sass migration from the webpack upgrade PR.
Node-sass is officially deprecated and all users are encouraged to switch to dart-sass, which has the same api, but is better supported. During the course of the webpack upgrade, we ran into several issues with our scss loading and dart-sass also provides much better debug error messages.
node-sasswithdart-sass.outputStyleneeded to be changed.sass-loaderneeded to be upgraded.'color'as'color.scss', which is potentially due to our weird convertScssToJs script, but I'm unsure what the connection there is. Only those two files required changes, despite color being used extensively, and no other imports needed to be changed apart from color.Links
dart-sass breaking changes
webpack upgrade doc
Testing story
Loaded main page and applab and everything looks styled.