add_frontend_server improvements - #4573
Merged
Merged
Conversation
… Knife, to reduce the window of race-conditions where we try to allocated two nodes with same name
Contributor
Author
There was a problem hiding this comment.
Oops, must have snuck in as I saved the file one last time.
Contributor
|
Think there's a typo at the top, suggest you have the output in real time on the user's screen as well. Your call on whether to do it. Otherwise LGTM |
philbogle
added a commit
that referenced
this pull request
Oct 15, 2015
add_frontend_server improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The add_frontend_server script has several new features:
-r ROLEallows a custom role to be specified, overriding the default for the environment. (For example-r front-end-ruby2_2will deploy a frontend using ruby2.2, as defined by that role.)