Re-merge "Allow projects with non-ascii asset filenames to be remixed" - #4570
Merged
Conversation
added 2 commits
October 14, 2015 14:27
Not sure why this wasn't also failing in other environments.
Member
|
Weird. we should probably be URI encoding s3_path too. |
Member
|
LGTM. It looks like of tricky to URL-escape s3_path since it's used in a few places including some where we don't really need to escape it, and apparently this is only giving us problems when copying assets anyway. |
joshlory
pushed a commit
that referenced
this pull request
Oct 14, 2015
Re-merge "Allow projects with non-ascii asset filenames to be remixed"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4516, re-merging #4481 with a fix for the failing test: a6518b8.
No idea why this only failed in the
RACK_ENV=testenvironment and nowhere else.