Creates the skeleton of a Search for Teachers page. - #4568
Merged
Conversation
…s these up to the display. Adds a column for the number of students associated with the teacher. Changes routing appropriately.
Contributor
Author
|
When reviewing, please confirm that I've done all the necessary authentication stuff to require admin access. |
…ltering was done.
Contributor
There was a problem hiding this comment.
yes, this is requiring admin access. You can write a unit test, there should be some examples in ReportsControllerTest
…ires being a logged-in admin.
Contributor
There was a problem hiding this comment.
we use json style for hashes when possible, eg: {method: 'get'}
Contributor
|
LGTM, except for some style nits and testing. If you need to get this out soon for some users and are continue to work on it, feel free to postpone testing for further iterations. I assume the functionality will become more complex then and testing will be more necessary... |
ashercodeorg
added a commit
that referenced
this pull request
Oct 15, 2015
Creates the skeleton of a Search for Teachers page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Later iterations will add functionality and search features to the page.
Note that this PR began as PR#4331. It is being moved here because of git issues.