Revert "Revert "Replace term "storage apps" with "projects""" - #45656
Merged
maureensturgeon merged 2 commits intoApr 5, 2022
Merged
Conversation
maureensturgeon
marked this pull request as ready for review
April 5, 2022 18:30
bethanyaconnor
approved these changes
Apr 5, 2022
maureensturgeon
deleted the
revert-45655-revert-45612-maureen/LP-2272-storage-apps-cleanup-2
branch
April 5, 2022 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #45655
Original PR: #45612
The issue that was caught in test was that I was using the alias for the column in a Sequel query, this alias can only be used in Active Record queries since the AR model is where the alias is defined.