Skip to content

Update tasks to account for migration of projects - #45653

Merged
Sam-Hutchins merged 3 commits into
stagingfrom
add_projects_to_replication_after_migration
Apr 6, 2022
Merged

Update tasks to account for migration of projects#45653
Sam-Hutchins merged 3 commits into
stagingfrom
add_projects_to_replication_after_migration

Conversation

@Sam-Hutchins

@Sam-Hutchins Sam-Hutchins commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

We are updating tasks to account for the migration of projects from pegasus to dashboard in the replication task. This comes as a required action item from this PR which moved the two affected tables from pegasus to dashboard.

Links

Testing story

@cat5inthecradle tested:

> bundle exec rake stack:data:validate RAILS_ENV=production

GetSecretValue: production/cdo/slack_token
GetSecretValue: production/cdo/slack_bot_token
GetSecretValue: production/cdo/db_writer
GetSecretValue: production/cdo/redshift_username
GetSecretValue: production/cdo/redshift_password
Parameters:
RedshiftUsername: REDACTED
RedshiftPassword: REDACTED
Pending update for stack `DATA-production`:
Add AuroraReportingClusterDBParameters [AWS::RDS::DBClusterParameterGroup] 
Modify AuroraReportingReplicaDBParameters [AWS::RDS::DBParameterGroup] Properties (Parameters)
Modify AuroraWriterDBParameters [AWS::RDS::DBParameterGroup] Properties (Parameters)
Modify DMSCronPii [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)
Modify DMSCron [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)
Add PrimaryDBParameters [AWS::RDS::DBParameterGroup] 
Add ReportingDBParameters [AWS::RDS::DBParameterGroup] 

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

We are updating tasks to account for the migration of projects from pegasus to dashboard in the replication task.
@Sam-Hutchins
Sam-Hutchins requested review from a team April 5, 2022 17:52
Comment thread aws/dms/tasks.yml Outdated
- dashboard.peer_reviews
- dashboard.circuit_playground_discount_applications
- dashboard.circuit_playground_discount_codes
- dashboard.storage_apps

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pegasus.storage_apps was renamed to dashboard.projects

Comment thread aws/dms/tasks.yml Outdated
- dashboard.stages_standards
- dashboard.standard_categories
- dashboard.frameworks
- dashboard.user_storage_ids

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pegasus.user_storage_ids was renamed to dashboard.user_project_storage_ids

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing these out; I've updated the code.

@sureshc
sureshc requested a review from maureensturgeon April 5, 2022 22:08
The original PR did not include the table name changes in addition to the schema name changes; this includes that change.
@sureshc

sureshc commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Drop a note in #infrastructure when you’re ready for us to deploy this change. Let’s wait until the deploy is complete before merging.

@cat5inthecradle

Copy link
Copy Markdown
Contributor

Deployed this change successfully.

➜  bundle exec rake stack:data:validate RAILS_ENV=production             
GetSecretValue: production/cdo/slack_token
GetSecretValue: production/cdo/slack_bot_token
GetSecretValue: production/cdo/db_writer
GetSecretValue: production/cdo/redshift_username
GetSecretValue: production/cdo/redshift_password
Parameters:
RedshiftUsername: REDACTED
RedshiftPassword: REDACTED
Pending update for stack `DATA-production`:
Modify DMSCronPii [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)
Modify DMSCron [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)

➜  bundle exec rake stack:data:start RAILS_ENV=production
GetSecretValue: production/cdo/slack_token
GetSecretValue: production/cdo/slack_bot_token
GetSecretValue: production/cdo/db_writer
GetSecretValue: production/cdo/redshift_username
GetSecretValue: production/cdo/redshift_password
Parameters:
RedshiftUsername: REDACTED
RedshiftPassword: REDACTED
Pending update for stack `DATA-production`:
Modify DMSCronPii [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)
Modify DMSCron [AWS::DMS::ReplicationTask] Properties Replacement: Conditional (TableMappings)
Proceed? [y/n]
y
 Stack update requested, waiting for provisioning to complete...
..2022-04-06 22:12:12 UTC- DMSCronPii [UPDATE_IN_PROGRESS]
.2022-04-06 22:12:14 UTC- DMSCron [UPDATE_IN_PROGRESS]
.....2022-04-06 22:12:50 UTC- DMSCronPii [UPDATE_COMPLETE]
..2022-04-06 22:13:03 UTC- DMSCron [UPDATE_COMPLETE]
.2022-04-06 22:13:07 UTC- DATA-production [UPDATE_COMPLETE_CLEANUP_IN_PROGRESS]

Stack update complete.
Outputs:

@Sam-Hutchins
Sam-Hutchins merged commit b1b8a3a into staging Apr 6, 2022
@Sam-Hutchins
Sam-Hutchins deleted the add_projects_to_replication_after_migration branch April 6, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants