Migrate pegasus.storage_apps => dashboard.projects all ENVs - #45480
Merged
maureensturgeon merged 8 commits intoMar 30, 2022
Conversation
10 tasks
maureensturgeon
force-pushed
the
maureen/LP-2268-storage-apps-migration-all-envs
branch
from
March 28, 2022 22:21
721a69d to
7a34594
Compare
maureensturgeon
force-pushed
the
maureen/LP-2268-storage-apps-migration-all-envs
branch
from
March 28, 2022 23:41
5de9a6d to
2945297
Compare
maureensturgeon
changed the title
maureensturgeon
marked this pull request as ready for review
March 29, 2022 16:52
sureshc
reviewed
Mar 29, 2022
| # and there will be no previously existing storage_apps data, so the old pegasus table can be dropped. | ||
| # The view will be created for consistency across environments. | ||
| if is_table_already_exists_error && is_pegasus_table_empty | ||
| puts "projects has already been created, dropping pegasus storage_apps..." |
Contributor
There was a problem hiding this comment.
It might be safer for us to use CDO.log instead of puts. We have logic that treats any usage of puts in a cron job as an error that should result in a HoneyBadger notification and this migration will be run by our automated build job (/aws/ci_build) on non-production managed environments.
Contributor
There was a problem hiding this comment.
I could be wrong about puts (standard out) triggering a HoneyBadger error, but still probably more consistent for us to use CDO.log whenever possible.
sureshc
approved these changes
Mar 29, 2022
sureshc
left a comment
sureshc
left a comment
Contributor
There was a problem hiding this comment.
I don’t have enough context to provide useful feedback on the application logic changes, but the new schema.rb and the Sequel migration look great!
maureensturgeon
deleted the
maureen/LP-2268-storage-apps-migration-all-envs
branch
March 30, 2022 23:15
This was referenced Mar 31, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of storage_apps to dashboard to run on all environments once the migration has been completed in production (#45476). Also removes the DCDO flag which would switch between pegasus.storage_apps and dashboard.projects, and just points our code at dashboard.projects.
Links
Testing story
Tested various scenarios locally to ensure project-related code was working as expected. Including
PR Checklist: