Fix video tests that were breaking because of video dialog load race … - #4542
Closed
mehalshah wants to merge 1 commit into
Closed
Fix video tests that were breaking because of video dialog load race …#4542mehalshah wants to merge 1 commit into
mehalshah wants to merge 1 commit into
Conversation
…condition Tests will not reliably pass on localhost for mobile browser, because the emulator may pop up a dialog so skipping mobile
Contributor
|
Can this be abandoned now that #4562 is merged? It looks like the same set of changes. |
Contributor
Author
|
Yes On Wed, Oct 14, 2015 at 1:23 PM, Josh Lory notifications@github.com wrote:
Mehal Shah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…condition
Tests will not reliably pass on localhost for mobile browser, because the emulator may pop up a dialog so skipping mobile